Don't mock non-enum accessors #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @AsaAyers |
I found the comment and code a little confusing. The comment talks about excluding but the code is including the opposite. Maybe the comment should say to only include accessors if they are they are enumerable? |
|
Yeah, OK, I'll change the comment. |
DmitrySoshnikov
force-pushed
the
mocker_getters
branch
from
2b74325 to
63ebb80
Compare
DmitrySoshnikov
added a commit
that referenced
this pull request
Jun 7, 2015
Don't mock non-enum accessors
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't mock non-enumerable accessors yet: they may throw, and fail in the mocker, when the mocker tries to get the value by the slot. Fixes #389, #380.