-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop running TS builds on CI beyond dedicated lint job #8346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to remove the reference at the bottom as well.
Could we just skip the ts compilation? yarn --ignore-scripts && node scripts/build
. I did see it passing once, but it's failing all the time, so I'm down with either way
+1 for skipping TS until we're sure the next release will be 25 Yeah I reran like 5-10 times on one of my PRs until it passed :D |
|
Anyway |
Hmm, |
Could probably do this for all CI builds to speed it up (leaving it in the "lint and typecheck" job) |
Codecov Report
@@ Coverage Diff @@
## master #8346 +/- ##
==========================================
- Coverage 62.19% 62.19% -0.01%
==========================================
Files 266 266
Lines 10701 10699 -2
Branches 2603 2604 +1
==========================================
- Hits 6656 6654 -2
Misses 3459 3459
Partials 586 586
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
We're dropping Node 6 support shortly and it's already failing on CI because it can't compile the TypeScript without dying. Stop running it now since it's failing regardless.
Test plan