Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop running TS builds on CI beyond dedicated lint job #8346

Merged
merged 14 commits into from
Apr 22, 2019

Conversation

scotthovestadt
Copy link
Contributor

Summary

We're dropping Node 6 support shortly and it's already failing on CI because it can't compile the TypeScript without dying. Stop running it now since it's failing regardless.

Test plan

  • CI should stop running Node 6.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove the reference at the bottom as well.


Could we just skip the ts compilation? yarn --ignore-scripts && node scripts/build. I did see it passing once, but it's failing all the time, so I'm down with either way

@jeysal
Copy link
Contributor

jeysal commented Apr 19, 2019

+1 for skipping TS until we're sure the next release will be 25

Yeah I reran like 5-10 times on one of my PRs until it passed :D

@scotthovestadt
Copy link
Contributor Author

--ignore-scripts should good, I'll try that.

@Connormiha
Copy link
Contributor

Anyway Nodejs Team will drop support of v6.* 30 april 2019.
https://github.com/nodejs/Release#release-schedule

@SimenB
Copy link
Member

SimenB commented Apr 22, 2019

Hmm, ignore-scripts skips postinstall for dependencies as well, which means the cached version of weak messes us up. I'll try a separate cache. if that doesn't work, I can setup a script deleting postinstall from our own package.json and run it for node 6

@SimenB SimenB changed the title Stop running Node 6 on CI. Stop running TS builds on Node 6 on CI. Apr 22, 2019
@SimenB
Copy link
Member

SimenB commented Apr 22, 2019

Could probably do this for all CI builds to speed it up (leaving it in the "lint and typecheck" job)

@codecov-io
Copy link

codecov-io commented Apr 22, 2019

Codecov Report

Merging #8346 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8346      +/-   ##
==========================================
- Coverage   62.19%   62.19%   -0.01%     
==========================================
  Files         266      266              
  Lines       10701    10699       -2     
  Branches     2603     2604       +1     
==========================================
- Hits         6656     6654       -2     
  Misses       3459     3459              
  Partials      586      586
Impacted Files Coverage Δ
packages/jest-reporters/src/summary_reporter.ts 39.39% <0%> (-0.91%) ⬇️
packages/jest-resolve/src/index.ts 44.11% <0%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd415e7...5a6b176. Read the comment docs.

@SimenB SimenB changed the title Stop running TS builds on Node 6 on CI. Stop running TS builds on CI beyond dedicated lint job Apr 22, 2019
@SimenB SimenB merged commit 609ae45 into jestjs:master Apr 22, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants