Simplify async .rejects examples

[bschlenk]

The docs state that "If the promise is fulfilled, the test will automatically fail", so it is not necessary to include the expect.assertions(1) calls since the tests will fail automatically if the promise doesn't reject.

Summary

Test plan

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[codecov-io]

Codecov Report

Merging #8965 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #8965   +/-   ##
======================================
  Coverage    64.2%   64.2%           
======================================
  Files         276     276           
  Lines       11718   11718           
  Branches     2868    2868           
======================================
  Hits         7523    7523           
  Misses       3563    3563           
  Partials      632     632

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1693028...19782da. Read the comment docs.

[jeysal]

Thanks for bringing this up. In my opinion, it is still a good idea and should be recommended to use expect.assertions as a safeguard once async things are involved, because it is easy to forget to return/await the expect.resolves.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[bschlenk]

That’s true, it would protect against forgetting to return the promise. However, for this example in particular, it made me question whether rejects actually fails when the Promise resolves okay.

Maybe it would be better to update the text to say that expect.assertions is recommended for that reason, but not required for the test to work?

[jeysal]

Yeah, mentioning that it is recommended to prevent the common mistake of forgetting to await / return the expect.resolves sounds good to me!

[SimenB]

Please update the versioned docs as well when incorporating @jeysal's feedback 🙂

[bschlenk]

Looks like #9149 was merged in which addresses this PR!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.