-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jest-runner-vscode #9542
Add jest-runner-vscode #9542
Conversation
Hi @bmealhouse! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #9542 +/- ##
=======================================
Coverage 65.03% 65.03%
=======================================
Files 283 283
Lines 12113 12113
Branches 3000 3000
=======================================
Hits 7878 7878
Misses 3597 3597
Partials 638 638 Continue to review full report at Codecov.
|
Hey! It seems like your runner is to actually run Jest itself? The runners linked are invoked by Jest to run some other tool. Seems like it's the wrong section? I've never used VS Code, could you explain a bit about how your runner is to be used? |
Hi @SimenB, thanks for the quick response! Yes, The purpose of the package is to use Jest as a test runner for VS Code extension integration tests. When running a VS Code extension integration test suite, VS Code starts a new instance VS Code (called the Extension Development Host), which has full access to the VS Code API. Maybe a better name for the package would be I've been using Jest for a long time now, and when I started building my VS Code extension, shifty, I was not happy with Mocha (the default test runner for VS Code extensions). Snapshot testing is extremely valuable to me! I want Jest to have a great testing story for VS Code extension development, so this is my initial work to make it easier for others. Feel free to pull down the code for shifty and run the tests to see how it works. Alternatively, you could pull down the helloworld-jest-test-sample to test it out as well. Let me know if you have any other questions or feedback. |
@SimenB - I'm closing this PR since |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Mocha is the only documented test runner for building VS Code extensions so I'm working with the VS Code team to have Jest documented as well (microsoft/vscode-docs#3363).
I would like to add jest-runner-vscode to the list of examples in the
runner
section of the Configuring Jest docs.I'm also curious if this warrants a "Testing VS Code Extensions" under the Framework Guides in the sidebar?
Test plan