Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed documentation for setupFilesAfterEnv to correctly state that this executes per "test file" and not per "test" #9651

Merged
merged 4 commits into from
Mar 11, 2020
Merged

Fixed documentation for setupFilesAfterEnv to correctly state that this executes per "test file" and not per "test" #9651

merged 4 commits into from
Mar 11, 2020

Conversation

ykns
Copy link
Contributor

@ykns ykns commented Mar 10, 2020 •
edited
Loading

This is confirmed with the setupFilesAfterEnv e2e tests

@facebook-github-bot
Copy link
Contributor

Hi @ykns!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@ykns ykns changed the title Update Configuration.md setupFilesAfterEnv Fixed documentation for setupFilesAfterEnv to correctly state that this executes per test file and not per test Mar 10, 2020
@ykns ykns changed the title Fixed documentation for setupFilesAfterEnv to correctly state that this executes per test file and not per test Fixed documentation for setupFilesAfterEnv to correctly state that this executes per "test file" and not per "test" Mar 10, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

SimenB
SimenB approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! could you update the versioned docs as well?
image

they might not all have this (it was introduced in jest v24), but maybe the old setupTestFrameworkScriptFile one is wrong?

Fixed version docs for setupFilesAfterEnv to correctly state that thi…
7246c36 
…s executes per "test file" and not per "test"
@ykns ykns mentioned this pull request Mar 11, 2020
Closed
@SimenB SimenB merged commit 1c50413 into jestjs:master Mar 11, 2020
@SimenB
Copy link
Member

SimenB commented Mar 11, 2020

Thanks!

sthagen added a commit to sthagen/facebook-jest that referenced this pull request Mar 12, 2020
@sthagen
Merge pull request #4 from facebook/master
e7aa5e9 
Fixed documentation for setupFilesAfterEnv to correctly state t… (jestjs#9651)
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ykns @facebook-github-bot @SimenB