[envsec] Changes to allow launchpad to update #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohsenari
approved these changes
Oct 11, 2023
mikeland73
added a commit
to jetify-com/launchpad
that referenced
this pull request
Oct 11, 2023
## Summary Update to newest version of envsec. Needs to be updated after jetify-com/opensource#174 is merged. ## How was it tested? Untested, will test by confirming secrets are still accessible and savable. ## Is this change backwards-compatible? Should be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For launchpad to update we need:
ToLowerIntroduced in [envsec] fix ls envname bug #118. This means envsec will be case sensitive. Note that the comments in that PR are not strictly correct, most commands do not doToLoweron environment, onlylsandexecdid.How was it tested?
Compiled launchpad with updated version of envsec and tested envsec commands (set, ls, exec, rm)