Fixes #5931 - SslConnection should implement getBytesIn()/getBytesOut().

Make sure the connection is closed before the assertions.

Signed-off-by: Simone Bordet <[email protected]>

jetty-client/src/test/java/org/eclipse/jetty/client/HttpClientTLSTest.java

@@ -48,6 +48,7 @@
 import org.eclipse.jetty.http.HttpStatus;
 import org.eclipse.jetty.io.ByteBufferPool;
 import org.eclipse.jetty.io.ClientConnectionFactory;
+import org.eclipse.jetty.io.Connection;
 import org.eclipse.jetty.io.ConnectionStatistics;
 import org.eclipse.jetty.io.EndPoint;
 import org.eclipse.jetty.io.ssl.SslClientConnectionFactory;
@@ -1009,21 +1010,40 @@ public void testForcedNonDomainSNI() throws Exception
     @Test
     public void testBytesInBytesOut() throws Exception
     {
+        CountDownLatch latch = new CountDownLatch(1);
         SslContextFactory serverTLSFactory = createServerSslContextFactory();
         startServer(serverTLSFactory, new EmptyServerHandler());
-        ConnectionStatistics serverStats = new ConnectionStatistics();
+        ConnectionStatistics serverStats = new ConnectionStatistics()
+        {
+            @Override
+            public void onClosed(Connection connection)
+            {
+                super.onClosed(connection);
+                latch.countDown();
+            }
+        };
         connector.addManaged(serverStats);
 
         SslContextFactory clientTLSFactory = createClientSslContextFactory();
         startClient(clientTLSFactory);
-        ConnectionStatistics clientStats = new ConnectionStatistics();
+        ConnectionStatistics clientStats = new ConnectionStatistics()
+        {
+            @Override
+            public void onClosed(Connection connection)
+            {
+                super.onClosed(connection);
+                latch.countDown();
+            }
+        };
         client.addManaged(clientStats);
 
         ContentResponse response = client.newRequest("https://localhost:" + connector.getLocalPort())
             .header(HttpHeader.CONNECTION, HttpHeaderValue.CLOSE.asString())
             .send();
         assertEquals(HttpStatus.OK_200, response.getStatus());
 
+        assertTrue(latch.await(5, TimeUnit.SECONDS));
+
         assertThat(clientStats.getSentBytes(), Matchers.greaterThan(0L));
         assertEquals(clientStats.getSentBytes(), serverStats.getReceivedBytes());
         assertThat(clientStats.getReceivedBytes(), Matchers.greaterThan(0L));