Fix #8536 HotSwap start race

Don't stop until after new handler installed.
jetty · Sep 3, 2022 · 7087dd0 · elipsion · Sep 6, 2022 · 7087dd0
1 parent f2e9744
commit 7087dd0
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/jetty-server/src/main/java/org/eclipse/jetty/server/handler/HotSwapHandler.java b/jetty-server/src/main/java/org/eclipse/jetty/server/handler/HotSwapHandler.java
@@ -65,10 +65,20 @@ public void setHandler(Handler handler)
         try
         {
             Server server = getServer();
+            if (handler == _handler)
+                return;
+
+            Handler oldHandler = _handler;
             if (handler != null)
+            {
                 handler.setServer(server);
-            updateBean(_handler, handler, true);
+                addBean(handler, true);
+                if (oldHandler != null && oldHandler.isStarted())
+                    handler.start();
+            }
             _handler = handler;
+            if (oldHandler != null)
+                removeBean(oldHandler);
         }
         catch (Exception e)
         {