NPE when forwarding a request to default servlet which should redirect to a subdirectory with trailing slash #10558

grgrzybek · 2023-09-20T10:26:39Z

Jetty version(s)
12.0.1

Java version/vendor (use: java -version)

$ java -version
java version "17.0.8" 2023-07-18 LTS
Java(TM) SE Runtime Environment (build 17.0.8+9-LTS-211)
Java HotSpot(TM) 64-Bit Server VM (build 17.0.8+9-LTS-211, mixed mode, sharing)

OS type/version

$ uname -srv
Linux 6.4.15-200.fc38.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Sep  7 00:25:01 UTC 2023

Description
When forwarding a request to default servlet using a directory without trailing slash and with welcome files configured, instead of getting redirect to such directory with trailing slash (so welcome file resolution happens after redirect), I'm getting NPE:

java.lang.NullPointerException: Cannot invoke "String.length()" because "s" is null
	at org.eclipse.jetty.util/org.eclipse.jetty.util.AbstractTrie.get(AbstractTrie.java:66)
	at org.eclipse.jetty.server/org.eclipse.jetty.server.Request.getServerPort(Request.java:459)
	at org.eclipse.jetty.server/org.eclipse.jetty.server.Request.toRedirectURI(Request.java:572)
	at org.eclipse.jetty.server/org.eclipse.jetty.server.Response.sendRedirect(Response.java:317)
	at org.eclipse.jetty.server/org.eclipse.jetty.server.Response.sendRedirect(Response.java:265)
	at org.eclipse.jetty.server/org.eclipse.jetty.server.Response.sendRedirect(Response.java:243)
	at org.eclipse.jetty.server/org.eclipse.jetty.server.ResourceService.sendRedirect(ResourceService.java:239)
	at org.eclipse.jetty.server/org.eclipse.jetty.server.ResourceService.sendWelcome(ResourceService.java:465)
	at org.eclipse.jetty.server/org.eclipse.jetty.server.ResourceService.doGet(ResourceService.java:174)
	at org.eclipse.jetty.ee10.servlet/org.eclipse.jetty.ee10.servlet.DefaultServlet.doGet(DefaultServlet.java:534)
	at [email protected]/jakarta.servlet.http.HttpServlet.service(HttpServlet.java:527)
	at [email protected]/jakarta.servlet.http.HttpServlet.service(HttpServlet.java:614)
	at org.eclipse.jetty.ee10.servlet/org.eclipse.jetty.ee10.servlet.ServletHolder.handle(ServletHolder.java:736)
	at org.eclipse.jetty.ee10.servlet/org.eclipse.jetty.ee10.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1608)
	at org.eclipse.jetty.ee10.servlet/org.eclipse.jetty.ee10.servlet.ServletHandler$MappedServlet.handle(ServletHandler.java:1541)
	at org.eclipse.jetty.ee10.servlet/org.eclipse.jetty.ee10.servlet.Dispatcher.forward(Dispatcher.java:124)
	at org.eclipse.jetty.ee10.servlet/org.eclipse.jetty.ee10.servlet.DispatcherTest$ForwardServlet.doGet(DispatcherTest.java:1057)
	at [email protected]/jakarta.servlet.http.HttpServlet.service(HttpServlet.java:527)
	at [email protected]/jakarta.servlet.http.HttpServlet.service(HttpServlet.java:614)
	at org.eclipse.jetty.ee10.servlet/org.eclipse.jetty.ee10.servlet.ServletHolder.handle(ServletHolder.java:736)
	at org.eclipse.jetty.ee10.servlet/org.eclipse.jetty.ee10.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1608)
	at org.eclipse.jetty.ee10.servlet/org.eclipse.jetty.ee10.servlet.ServletHandler$MappedServlet.handle(ServletHandler.java:1541)
	at org.eclipse.jetty.ee10.servlet/org.eclipse.jetty.ee10.servlet.ServletChannel.dispatch(ServletChannel.java:885)
	at org.eclipse.jetty.ee10.servlet/org.eclipse.jetty.ee10.servlet.ServletChannel.handle(ServletChannel.java:490)
	at org.eclipse.jetty.ee10.servlet/org.eclipse.jetty.ee10.servlet.ServletHandler.handle(ServletHandler.java:463)
	at org.eclipse.jetty.server/org.eclipse.jetty.server.handler.ContextHandler.handle(ContextHandler.java:811)
	at org.eclipse.jetty.server/org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:177)
	at org.eclipse.jetty.server/org.eclipse.jetty.server.Handler$Wrapper.handle(Handler.java:712)
	at org.eclipse.jetty.server/org.eclipse.jetty.server.Server.handle(Server.java:176)
	at org.eclipse.jetty.server/org.eclipse.jetty.server.internal.HttpChannelState$HandlerInvoker.run(HttpChannelState.java:648)
	at org.eclipse.jetty.server/org.eclipse.jetty.server.internal.HttpConnection.onFillable(HttpConnection.java:471)
	at org.eclipse.jetty.io/org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:322)
	at org.eclipse.jetty.io/org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:100)
	at org.eclipse.jetty.io/org.eclipse.jetty.io.ByteArrayEndPoint.lambda$new$0(ByteArrayEndPoint.java:58)
	at org.eclipse.jetty.util/org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:969)
	at org.eclipse.jetty.util/org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.doRunJob(QueuedThreadPool.java:1194)
	at org.eclipse.jetty.util/org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1149)
	at java.base/java.lang.Thread.run(Thread.java:833)

The problem is that I have an instance of org.eclipse.jetty.ee10.servlet.Dispatcher$ForwardRequest like this:

request = {org.eclipse.jetty.ee10.servlet.ServletCoreRequest@3063} 
 _httpFields: org.eclipse.jetty.http.HttpFields  = {org.eclipse.jetty.http.ImmutableHttpFields@3068} "Connection: close\r\nHost: local\r\n\r\n"
 _servletContextRequest: org.eclipse.jetty.ee10.servlet.ServletContextRequest  = {org.eclipse.jetty.ee10.servlet.ServletContextRequest@3067} 
 _servletRequest: jakarta.servlet.http.HttpServletRequest  = {org.eclipse.jetty.ee10.servlet.Dispatcher$ForwardRequest@3066} 
  _httpServletRequest: jakarta.servlet.http.HttpServletRequest  = {org.eclipse.jetty.ee10.servlet.ServletApiRequest@3404} 
  _params: org.eclipse.jetty.util.MultiMap  = null
  org.eclipse.jetty.ee10.servlet.Dispatcher$ParameterRequestWrapper.this$0: org.eclipse.jetty.ee10.servlet.Dispatcher  = {org.eclipse.jetty.ee10.servlet.Dispatcher@3405} "Dispatcher@0x5e43b83c{null,/context/subdir}"
  request: jakarta.servlet.ServletRequest  = {org.eclipse.jetty.ee10.servlet.ServletApiRequest@3404} 
  this$0: org.eclipse.jetty.ee10.servlet.Dispatcher  = {org.eclipse.jetty.ee10.servlet.Dispatcher@3405} "Dispatcher@0x5e43b83c{null,/context/subdir}"
 _uri: org.eclipse.jetty.http.HttpURI  = {org.eclipse.jetty.http.HttpURI$Immutable@3064} "/context/subdir?do=req.echo&uri=/subdir"

and org.eclipse.jetty.server.Request#getServerPort() uses:

// Is there a scheme with a default port?
HttpScheme scheme = HttpScheme.CACHE.get(request.getHttpURI().getScheme());

and this ServletCoreRequest@3063 has this _uri:

result = {org.eclipse.jetty.http.HttpURI$Immutable@3064} "/context/subdir?do=req.echo&uri=/subdir"
 _canonicalPath: java.lang.String  = {@3421} "/context/subdir"
 _fragment: java.lang.String  = null
 _host: java.lang.String  = null
 _param: java.lang.String  = null
 _path: java.lang.String  = {@3421} "/context/subdir"
 _port: int  = -1
 _query: java.lang.String  = {@3422} "do=req.echo&uri=/subdir"
 _scheme: java.lang.String  = null
 _uri: java.lang.String  = {@3065} "/context/subdir?do=req.echo&uri=/subdir"
 _user: java.lang.String  = null
 _violations: java.util.EnumSet  = {java.util.RegularEnumSet@3423}  size = 0

How to reproduce?

I've prepared a unit test using current jetty-12.0.x branch here: grgrzybek@066c2ca

This is part of my continued work after #9910 has been explained.

The text was updated successfully, but these errors were encountered:

janbartel · 2023-09-21T00:16:41Z

@grgrzybek yep, this is an issue. PR is on the way.

janbartel · 2023-09-21T03:46:51Z

See PR #10560

grgrzybek · 2023-09-21T05:06:31Z

Thank you for quick response!

* Issue #10558 Fix ee10 redirect during forward, add ee9 test

janbartel · 2023-09-24T23:23:36Z

Fixed via #10560

grgrzybek · 2023-09-26T06:57:22Z

Thanks - I checked in Pax Web and everything works perfectly!

grgrzybek added the Bug For general bugs on Jetty side label Sep 20, 2023

joakime added this to Jetty 12.0.3 Sep 20, 2023

janbartel added a commit that referenced this issue Sep 21, 2023

Issue #10558 Fix ee10 redirect during forward, add ee9 test

f322487

janbartel mentioned this issue Sep 21, 2023

Issue #10558 Fix ee10 redirect during forward, add ee9 test #10560

Merged

janbartel self-assigned this Sep 21, 2023

janbartel moved this to 🏗 In progress in Jetty 12.0.3 Sep 21, 2023

janbartel added a commit that referenced this issue Sep 23, 2023

Issue #10558 Fix ee10 redirect during forward, add ee9 test (#10560)

65d5664

* Issue #10558 Fix ee10 redirect during forward, add ee9 test

janbartel closed this as completed Sep 24, 2023

github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.3 Sep 24, 2023

grgrzybek mentioned this issue Sep 26, 2023

NPE when including a directory that should be resolved with servlet-mapped welcome file #10582

Closed

joakime mentioned this issue Sep 26, 2023

NPE thrown when sending redirects for folder address after the request is filtered by spring security #10579

Closed

joakime added this to Jetty 12.0.3 - FROZEN Oct 12, 2023

joakime moved this to ✅ Done in Jetty 12.0.3 - FROZEN Oct 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NPE when forwarding a request to default servlet which should redirect to a subdirectory with trailing slash #10558

NPE when forwarding a request to default servlet which should redirect to a subdirectory with trailing slash #10558

grgrzybek commented Sep 20, 2023

janbartel commented Sep 21, 2023

janbartel commented Sep 21, 2023

grgrzybek commented Sep 21, 2023

janbartel commented Sep 24, 2023

grgrzybek commented Sep 26, 2023

NPE when forwarding a request to default servlet which should redirect to a subdirectory with trailing slash #10558

NPE when forwarding a request to default servlet which should redirect to a subdirectory with trailing slash #10558

Comments

grgrzybek commented Sep 20, 2023

janbartel commented Sep 21, 2023

janbartel commented Sep 21, 2023

grgrzybek commented Sep 21, 2023

janbartel commented Sep 24, 2023

grgrzybek commented Sep 26, 2023