Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit demand control in WebSocket endpoints with only onWebSocketFrame() #11307

Closed
sbordet opened this issue Jan 23, 2024 · 1 comment
Closed

Explicit demand control in WebSocket endpoints with only onWebSocketFrame() #11307

sbordet opened this issue Jan 23, 2024 · 1 comment
Assignees
@lachlan-roberts
Labels
Bug For general bugs on Jetty side

Comments

@sbordet
Copy link
Contributor

sbordet commented Jan 23, 2024

Jetty version(s)
12+

Description
If a WebSocket endpoint only overrides onWebSocketFrame() it currently has no explicit control over the demand, because the implementation expects other methods to be present, and the other methods to control the demand explicitly.

There should be a way to explicitly control the demand if an application want to deal only with frames.
@sbordet sbordet added the Bug For general bugs on Jetty side label Jan 23, 2024
@sbordet sbordet mentioned this issue Jan 23, 2024
Merged
@sbordet
Copy link
Contributor Author

sbordet commented Jan 23, 2024

See #11304.

@lachlan-roberts lachlan-roberts mentioned this issue Feb 22, 2024
Merged
lachlan-roberts added a commit that referenced this issue Oct 3, 2024
@lachlan-roberts
Issue #11307 - Explicit demand control in WebSocket endpoints with on…
fbd66a5 
…ly onWebSocketFrame

Signed-off-by: Lachlan Roberts <[email protected]>
@lachlan-roberts lachlan-roberts mentioned this issue Oct 3, 2024
Merged
lachlan-roberts added a commit that referenced this issue Nov 15, 2024
@lachlan-roberts
Merge pull request #12342 from jetty/jetty-12.1.x-11307-websocket-fra…
4360d12 
…meHandler-demand

Issue #11307 - Explicit demand control in WebSocket endpoints with only onWebSocketFrame
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.1.0 Nov 15, 2024
@olamy olamy mentioned this issue Jan 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
Bug For general bugs on Jetty side
Projects
Jetty 12.1.0
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sbordet @lachlan-roberts