Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeprecationWarning Decorator #3764

Closed
gregw opened this issue Jun 11, 2019 · 2 comments · Fixed by #6260
Closed

DeprecationWarning Decorator #3764

gregw opened this issue Jun 11, 2019 · 2 comments · Fixed by #6260
Assignees
Milestone

Comments

@gregw
Copy link
Contributor

gregw commented Jun 11, 2019

The DeprecationWarning decorator is always added to the DecoratedObjectFactory in the constructor of ServletContextHandler.
However, over a stop/start cycle the factory is cleared and the decorator is not re-added.

Moreover, is it really our responsibility to always warn if a deprecated servlet is used? Could we not make this optional? Perhaps in jetty-10 we can have a DeprecatedConfiguration that will add this decorator in pre-configure (and thus will work over stop/start)?

@gregw gregw added this to the 10.0.x milestone Jun 11, 2019
@stale
Copy link

stale bot commented Jun 10, 2020

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Jun 10, 2020
@joakime joakime removed the Stale For auto-closed stale issues and pull requests label Jun 10, 2020
@joakime
Copy link
Contributor

joakime commented Jun 18, 2020

Stop / Start is not typical behavior.

The DeprecationWarning decorator notifies on many things, not just Servlets.
Add the obvious Filters and Listeners to the list, and then you start to see where this becomes useful.
As an example, we've had multiple reports that this helped folks understand that GzipFilter needed to be replaced as it was deprecated.

I say we don't bother with stop/start behavior and leave it like it is.

gregw added a commit that referenced this issue May 12, 2021
Add in doStart

Signed-off-by: Greg Wilkins <[email protected]>
@gregw gregw assigned gregw and unassigned joakime May 12, 2021
joakime added a commit that referenced this issue May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants