Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Preventers #5725

Closed
sbordet opened this issue Nov 24, 2020 · 3 comments · Fixed by #5839
Closed

Review Preventers #5725

sbordet opened this issue Nov 24, 2020 · 3 comments · Fixed by #5839
Assignees
@janbartel
Labels
Low Priority

Comments

@sbordet
Copy link
Contributor

sbordet commented Nov 24, 2020

Jetty version
10.0.x

Description
There are a number of "preventers" that are supposed to avoid classloader leaks.

Some of them are now invalid since either the issue has been solved in OpenJDK or the classes/fields they were doing heavy reflection on have been renamed/moved.

All of them need a review and possibly be moved to a different module to avoid polluting the jetty-util module-info.java with requires static.
@sbordet
Copy link
Contributor Author

sbordet commented Nov 24, 2020

See also #1923.

@sbordet sbordet mentioned this issue Nov 24, 2020
Merged
@janbartel janbartel self-assigned this Dec 22, 2020
@janbartel
Copy link
Contributor

In jetty-9.4, many of them can be marked as Deprecated, as they were fixed for eg jdk8. I think in jetty-10 we can remove them.

janbartel added a commit that referenced this issue Dec 22, 2020
@janbartel
Issue #5725 Review preventers.
440b518 
Note that any Preventer that is documented as being fixed prior to jdk11
should be deleted from jetty-10/11 when this change is merged through.

Signed-off-by: Jan Bartel <[email protected]>
@janbartel janbartel mentioned this issue Dec 22, 2020
Merged
@janbartel janbartel linked a pull request Dec 22, 2020 that will close this issue
Issue #5725 Review preventers. #5839
Merged
janbartel added a commit that referenced this issue Dec 24, 2020
@janbartel
Issue #5725 Review preventers. (#5839)
29c00eb 
Note that any Preventer that is documented as being fixed prior to jdk11
should be deleted from jetty-10/11 when this change is merged through.

Signed-off-by: Jan Bartel <[email protected]>
@janbartel
Copy link
Contributor

Fixed by #5839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janbartel janbartel

Labels
Low Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #5725 Review preventers. jetty/jetty.project
2 participants
@janbartel @sbordet