Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate units of HttpClient properties #8591

Closed
cowwoc opened this issue Sep 15, 2022 · 4 comments
Closed

Indicate units of HttpClient properties #8591

cowwoc opened this issue Sep 15, 2022 · 4 comments
Labels
Enhancement

Comments

@cowwoc
Copy link
Contributor

cowwoc commented Sep 15, 2022

Jetty version(s) 11.0.1

Enhancement Description

For example, I assume that HttpClient.setRequestBufferSize() and HttpClient.setResponseBufferSize() refer to a value in bytes but it would be helpful for the Javadoc to state this explicitly. Alternatively, rename the parameter name from say requestBufferSize to requestBufferSizeInBytes.
@sbordet
Copy link
Contributor

sbordet commented Sep 15, 2022

Care to contribute a pull request? Against jetty-10.0.x, we will merge forward. Thanks!

cowwoc added a commit to cowwoc/jetty.project that referenced this issue Oct 18, 2022
@cowwoc
Fixes jetty#8591: Indicate units of HttpClient properties.
46d0441
cowwoc added a commit to cowwoc/jetty.project that referenced this issue Oct 18, 2022
@cowwoc
Fixes jetty#8591: Indicate units of HttpClient properties.
12ae588
cowwoc added a commit to cowwoc/jetty.project that referenced this issue Oct 18, 2022
@cowwoc
Fixes jetty#8591: Indicate units of HttpClient properties.
7e11915
@cowwoc
Copy link
Contributor Author

cowwoc commented Oct 18, 2022

Done

@joakime
Copy link
Contributor

joakime commented Oct 18, 2022

Might want to link the PR here.
Looks like you went above and beyond with PRs for all three active branches.
We really only need 10.0.x and we'll merge forward.

@cowwoc
Copy link
Contributor Author

cowwoc commented Oct 18, 2022

@joakime Here you go: #8728

Sorry for the other PRs. I'll close the extra ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joakime @sbordet @cowwoc