Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Test - org.eclipse.jetty.http2.tests.TrailersTest.testTrailersSentByServerShouldNotSendEmptyDataFrame #8896

Closed
joakime opened this issue Nov 14, 2022 · 1 comment · Fixed by #9090
Closed

Flaky Test - org.eclipse.jetty.http2.tests.TrailersTest.testTrailersSentByServerShouldNotSendEmptyDataFrame #8896

joakime opened this issue Nov 14, 2022 · 1 comment · Fixed by #9090
Assignees
@sbordet
Labels
flaky-test

Comments

@joakime
Copy link
Contributor

joakime commented Nov 14, 2022

Jetty version(s)
Jetty 12

Description

Stacktrace

java.util.ConcurrentModificationException
	at java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1013)
	at java.base/java.util.ArrayList$Itr.next(ArrayList.java:967)
	at java.base/java.util.AbstractCollection.toString(AbstractCollection.java:456)
	at org.eclipse.jetty.http2.tests.TrailersTest.testTrailersSentByServerShouldNotSendEmptyDataFrame(TrailersTest.java:301)

Standard Error

Running org.eclipse.jetty.http2.tests.TrailersTest.testTrailersSentByServerShouldNotSendEmptyDataFrame()
2022-11-14 19:26:21.747:INFO :oejs.Server:main: jetty-12.0.0-SNAPSHOT; built: 2022-11-14T19:10:45.095Z; git: f1822c9720f1f33e268717972ad0c0e9c19b1045; jvm 17.0.2+8
2022-11-14 19:26:21.748:INFO :oejs.AbstractConnector:main: Started ServerConnector@2f4fc18{h2c, (h2c)}{0.0.0.0:38433}
2022-11-14 19:26:21.748:INFO :oejs.Server:main: Started oejs.Server@6e612122{STARTING}[12.0.0-SNAPSHOT,sto=0] @184775ms
2022-11-14 19:26:21.754:INFO :oejs.Server:main: Stopped oejs.Server@6e612122{STOPPING}[12.0.0-SNAPSHOT,sto=0]
2022-11-14 19:26:21.754:INFO :oejs.AbstractConnector:main: Stopped ServerConnector@2f4fc18{h2c, (h2c)}{0.0.0.0:0}
sbordet added a commit that referenced this issue Nov 15, 2022
@sbordet
Fixes #8896 - Flaky TrailersTest.
557490e 
In Jetty 12, demand after last frame invokes onDataAvailable(), so the latch needs to be counted down two times.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Copy link
Contributor

sbordet commented Nov 15, 2022

Fixed by 557490e.

@sbordet sbordet closed this as completed Nov 15, 2022
@olamy olamy mentioned this issue Dec 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbordet sbordet

Labels
flaky-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

keep matching exception to found errorpage jetty/jetty.project
2 participants
@joakime @sbordet