Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty 12 - Review Pool and Pool.Entry #9210

Closed
sbordet opened this issue Jan 26, 2023 · 1 comment · Fixed by #9211
Closed

Jetty 12 - Review Pool and Pool.Entry #9210

sbordet opened this issue Jan 26, 2023 · 1 comment · Fixed by #9211
Assignees
@sbordet
Labels
Bug For general bugs on Jetty side

Comments

@sbordet
Copy link
Contributor

sbordet commented Jan 26, 2023

Jetty version(s)
12+

Description
Classes Pool and Pool.Entry are concrete classes and as such difficult to extend/wrap.
In light of #9148, we need to review these classes and possibly make them interfaces, so it would be easier to inject different implementations, or to wrap an implementation with another.
@sbordet sbordet added the Bug For general bugs on Jetty side label Jan 26, 2023
@sbordet sbordet self-assigned this Jan 26, 2023
sbordet added a commit that referenced this issue Jan 26, 2023
@sbordet
Fixes #9210 - Jetty 12 - Review Pool and Pool.Entry
9a2c020 
* Extracted interface Pool, renamed implementation to ConcurrentPool.
* Extracted Pool.Entry as interface.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet sbordet linked a pull request Jan 26, 2023 that will close this issue
Fixes #9210 - Jetty 12 - Review Pool and Pool.Entry #9211
Merged
@joakime joakime moved this to 🏗 In progress in Jetty 12.0.0.beta0 - FROZEN Jan 26, 2023
sbordet added a commit that referenced this issue Jan 30, 2023
@sbordet
Fixes #9210 - Jetty 12 - Review Pool and Pool.Entry (#9211)
af6ecfe 
* Fixes #9210 - Jetty 12 - Review Pool and Pool.Entry

* Extracted interface Pool, renamed implementation to ConcurrentPool.
* Extracted Pool.Entry as interface.
* Moved StrategyType to ConcurrentPool.
* Made Pool.Factory.wrap() work in order to wrap Pool instances.
* Removed constructors that were explicitly taking Pool parameters, replaced by a single Pool.Factory parameter.
* Added javadocs.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Copy link
Contributor Author

sbordet commented Jan 30, 2023

Fixed by #9211.

@sbordet sbordet closed this as completed Jan 30, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.0.beta0 - FROZEN Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbordet sbordet

Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #9210 - Jetty 12 - Review Pool and Pool.Entry jetty/jetty.project
1 participant
@sbordet