Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handler passed to Handler in constructor a parent or child? #9946

Closed
gregw opened this issue Jun 22, 2023 · 0 comments · Fixed by #9948
Closed

Handler passed to Handler in constructor a parent or child? #9946

gregw opened this issue Jun 22, 2023 · 0 comments · Fixed by #9948
Assignees
@lorban
Labels
Bug For general bugs on Jetty side

Comments

@gregw
Copy link
Contributor

gregw commented Jun 22, 2023

Jetty version(s)
12

Description

In Handler.Wrapper we can now pass a handler in a constructor that is the child handler.
However, we still have (deprecated) constructors on some handlers, that take a passed handler as the parent.

We should do one or the other, as otherwise it is confusing. Probably keep the former as it is not deprecated, and so we should remove the later and uses of it (in XML as well?).
@gregw gregw added the Bug For general bugs on Jetty side label Jun 22, 2023
lorban added a commit that referenced this issue Jun 22, 2023
@lorban
#9946 Stop passing Handler in constructor as a parent
294bd67 
Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban mentioned this issue Jun 22, 2023
Merged
@lorban lorban linked a pull request Jun 22, 2023 that will close this issue
#9946 Stop passing Handler in constructor as a parent #9948
Merged
@lorban lorban moved this to 🏗 In progress in Jetty 12.0.0.beta3 Jun 22, 2023
lorban added a commit that referenced this issue Jun 23, 2023
@lorban
#9946 Stop passing Handler in constructor as a parent (#9948)
8f4a15c 
#9946 Stop passing Handler in constructor as a parent

Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban closed this as completed Jun 23, 2023
@lorban lorban moved this from 🏗 In progress to ✅ Done in Jetty 12.0.0.beta3 Jun 23, 2023
@lorban lorban mentioned this issue Jun 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorban lorban

Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#9946 Stop passing Handler in constructor as a parent jetty/jetty.project
2 participants
@gregw @lorban