add SizeLimitHandler to Jetty-12 #10071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
gregw
requested changes
Jul 6, 2023
There was a problem hiding this comment.
This looks good, but can you also add a test where this is put inside an ee10 ServletContextHandler, perhaps with a GzipHandler also in the context. It is not needed to test this handler, but I want to make sure we test the ability to nest core handlers inside ee10 contexts. We probably also need to work out simple methods to configure/deploy
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
gregw
requested changes
Jul 7, 2023
| protected void doPost(HttpServletRequest req, HttpServletResponse resp) throws IOException | ||
| { | ||
| String requestContent = IO.toString(req.getInputStream()); | ||
| resp.getWriter().print(requestContent); |
There was a problem hiding this comment.
It would be good to test both if the size limit is broken incrementally and if it is broken by an initial large write.
There was a problem hiding this comment.
We do have this test, but not in the servlet version of the test using GZIP.
It is in SizeLimitHandlerTest.
gregw
approved these changes
Jul 14, 2023
lachlan-roberts
added
the
Sponsored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adapt the
SizeLimitHandlerfrom jetty 9.4 to the Jetty 12 core Handler style