Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #10131 - revert changes to ErrorRequest.getQueryString() and AsyncServletTest #10132

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Issue #10131 - revert changes to ErrorRequest.getQueryString() and AsyncServletTest #10132

merged 3 commits into from
Jul 20, 2023

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Jul 19, 2023 •
edited
Loading

Simple revert, not much else.

Added new test to ErrorPageTest for request.getQueryString() too.

@joakime joakime self-assigned this Jul 19, 2023
@joakime joakime added Bug For general bugs on Jetty side Jetty 12 labels Jul 19, 2023
@joakime joakime added this to the 12.0.x milestone Jul 19, 2023
@joakime joakime linked an issue Jul 19, 2023 that may be closed by this pull request
Review ERROR query-string handling #10131
Closed
@joakime joakime mentioned this pull request Jul 19, 2023
Closed
gregw
gregw approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like better.... but I think we need to do the full merge after this PR.

@joakime joakime merged commit 408f6a7 into jetty-12.0.x Jul 20, 2023
@joakime joakime deleted the fix/12.0.0/error-dispatch-query-string branch July 20, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

@sbordet sbordet Awaiting requested review from sbordet

@lachlan-roberts lachlan-roberts Awaiting requested review from lachlan-roberts

Assignees

@joakime joakime

Labels
Bug For general bugs on Jetty side
Projects
None yet
Milestone
12.0.x
Development

Successfully merging this pull request may close these issues.

Review ERROR query-string handling
2 participants
@joakime @gregw