Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #10131 - Test case showing ERROR param merging works as-is. #10133

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Jul 20, 2023

Turns out the existing HEAD of jetty-12.0.x does perform parameter merging with ERROR dispatch.

Adding testcase to validate this.

@joakime joakime added the Test label Jul 20, 2023
@joakime joakime requested a review from gregw July 20, 2023 19:08
@joakime joakime self-assigned this Jul 20, 2023
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we are correctly merging the parameters for both forward and error dispatches. The only problem is that for both we are not creating a merged query string.

@joakime
Copy link
Contributor Author

joakime commented Jul 21, 2023

So we are correctly merging the parameters for both forward and error dispatches. The only problem is that for both we are not creating a merged query string.

See past discussion on the topic of merging of query strings at #2074 (there's a lot of messages to go through, from multiple people, but it's an interesting read on how we've been interpreting the vague servlet spec in this regard)

@joakime joakime merged commit e587af9 into jetty-12.0.x Jul 21, 2023
@joakime joakime deleted the fix/12.0.x/error-param-merge branch July 21, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants