Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #10508 - honor Servlet spec behaviors for null in addHeader / setHeader calls #10510

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Issue #10508 - honor Servlet spec behaviors for null in addHeader / setHeader calls #10510

merged 2 commits into from
Sep 14, 2023

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Sep 13, 2023

  • Rework ResponseHeadersTest in ee10 to modern standards
  • Add testcases for addHeader / setHeader with nulls
  • Add testcases for addDateHeader / setDateHeader with nulls
  • Add testcases for addIntHeader / setIntHeader with nulls
  • Implement fix in ServletApiResponse for what the Servlet spec apidocs say for null parameters.

@joakime joakime added Bug For general bugs on Jetty side Specification For all industry Specifications (IETF / Servlet / etc) labels Sep 13, 2023
@joakime joakime requested a review from gregw September 13, 2023 16:02
@joakime joakime self-assigned this Sep 13, 2023
@joakime joakime added this to the 12.0.x milestone Sep 13, 2023
@joakime joakime linked an issue Sep 13, 2023 that may be closed by this pull request
Jetty 12 IllegalArgumentExeption when setting a HTTP header to null #10508
Closed
@joakime joakime mentioned this pull request Sep 13, 2023
Closed
@joakime joakime requested a review from sbordet September 13, 2023 16:30
@joakime
Copy link
Contributor Author

joakime commented Sep 13, 2023

Looks like the ee10 / Servlet 6 javadoc introduced language about handling nulls in setHeader / addHeader type calls.

See: https://github.com/jakartaee/servlet/blob/master/api/src/main/java/jakarta/servlet/http/HttpServletResponse.java#L261

These clarifications came from issue jakartaee/servlet#159 and were applied to ee10 / Servlet 6 in commit jakartaee/servlet@3767d7f

@joakime joakime merged commit 0068c91 into jetty-12.0.x Sep 14, 2023
@joakime joakime deleted the fix/12.0.x/ee10-response-addheader-null branch September 14, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamy olamy olamy approved these changes

@gregw gregw gregw approved these changes

@sbordet sbordet sbordet approved these changes

Assignees

@joakime joakime

Labels
Bug For general bugs on Jetty side Specification For all industry Specifications (IETF / Servlet / etc)
Projects
None yet
Milestone
12.0.x
Development

Successfully merging this pull request may close these issues.

Jetty 12 IllegalArgumentExeption when setting a HTTP header to null
4 participants
@joakime @olamy @gregw @sbordet