Provide a more helpful TimeoutException message

[garydgregory]

• One cannot tell what endpoint is at fault in a non-trivial configuration, for example, using an AsyncMiddleManServlet, is it the origin or the client?
• The TimeoutException message now contains the endpoint causing the timeout

[sbordet]

@garydgregory I have doubts that we can accept this, as we need to be very careful about exposing IP addresses (even internal ones) in exception messages that may be seen by remote users.

In AsyncMiddleManServlet you have onClientRequestFailure() and onProxyResponseFailure() to determine whether it is the client or the server.

@joakime @gregw @lorban opinions about disclosing the IP in the exception?

[garydgregory]

Hi all,

In the failure methods, I cannot tell from the throwable which endpoint threw the exception.

Would you rather the TimeoutException point to the endpoint that created it? This could only be done in a new custom TimeoutException subclass.

[sbordet]

@garydgregory the failure methods have the request objects, and you can call e.g. HttpServletRequest.getRemoteAddr().
Did you try and it's not working?

[garydgregory]

@garydgregory the failure methods have the request objects, and you can call e.g. HttpServletRequest.getRemoteAddr(). Did you try and it's not working?

Hello @sbordet

Thank you for your suggestion. I'll try using the 'remote' methods in our servlet and see what get in our logs... TY!

[garydgregory]

FYI I still have some testing to do and reviewing of our logs.

[sbordet]

@garydgregory do you have an update? I'm inclined to close this, as the "remote" methods should be enough for your use case?

[garydgregory]

@sbordet
Yes, sorry about the delay. I'll close this.