Fixes #12436 - Allow headers size extend to maxRequestHeadersSize in http client. #12544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…http client. Reworked contribution by @shaoxt in light of the work done in #12351. Signed-off-by: Simone Bordet <[email protected]>
|
Thanks a lot to make this PR green. |
gregw
approved these changes
Nov 17, 2024
|
Thanks a lot to modify and merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially contributed by @shaoxt, but reworked in light of #12351.
For HTTP/1, headers are initially generated using
HttpClient.getRequestBufferSize().If that overflows, headers are generated again with
HttpClient.getMaxRequestHeadersSize().This allows most of the requests to use a smaller buffer.