-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #5019 - hot-reload SSL certificates if keystore file changed #5042
Conversation
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
…tart.jar Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
…nkins Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
@lachlan-roberts please redo this PR as follows:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See PR comment.
…tty-server Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
@sbordet I did all these, but moved the tests to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes.
jetty-util/src/main/java/org/eclipse/jetty/util/ssl/SslKeyStoreScanner.java
Outdated
Show resolved
Hide resolved
jetty-util/src/main/java/org/eclipse/jetty/util/ssl/SslKeyStoreScanner.java
Outdated
Show resolved
Hide resolved
jetty-util/src/main/java/org/eclipse/jetty/util/ssl/SslKeyStoreScanner.java
Outdated
Show resolved
Hide resolved
jetty-util/src/main/java/org/eclipse/jetty/util/ssl/SslKeyStoreScanner.java
Outdated
Show resolved
Hide resolved
jetty-util/src/main/java/org/eclipse/jetty/util/ssl/SslKeyStoreScanner.java
Outdated
Show resolved
Hide resolved
jetty-util/src/main/java/org/eclipse/jetty/util/ssl/SslKeyStoreScanner.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some documentation in configuring-ssl.adoc
.
jetty-util/src/main/java/org/eclipse/jetty/util/ssl/KeyStoreScanner.java
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <[email protected]>
…l if reload failed Signed-off-by: Lachlan Roberts <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add *.adoc documentation as well.
jetty-util/src/main/java/org/eclipse/jetty/util/ssl/SslContextFactory.java
Outdated
Show resolved
Hide resolved
…extFactory Signed-off-by: Lachlan Roberts <[email protected]>
Does the hot reload work if the keystore file is a soft link ? |
I wouldn't expect it to, as the soft link itself wasn't updated, meaning there's no file change (last modified) detectable. |
@mantryashutosh it should still work if the keystore file is a soft link, we even have a test for this at |
that's great, thank you so much @lachlan-roberts . Will test it out |
Issue #5019
Added an
ssl-reload
module which usesScanner
to monitor the keystore file registered with theSslContextFactory
and reloads the keystore file if it detects any changes.