Issue #4430 Quickstart duplicate servlets,filters,listeners from context #5311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4430
If a context xml file configures servlets, filters or listeners, these get put into the quickstart-web.xml file leading to duplicates because the context xml file is re-applied when the context restarts.
This fix checks the Source of the servlet, servlet-mapping, filter, filter-mapping and listener before generating into quickstart-web.xml: any that were added via embedding (ie jetty api/xml) are ignored.
I've marked this for 10.0.0, but happy if it is delayed until 10.0.1.
It will probably also need to be backported (with modifications) for jetty-9.4.x as well.