Fix #5939 unwrap ServletException #5958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #5939 unwrap ServletException Signed-off-by: Greg Wilkins <[email protected]>
reverted default to false Signed-off-by: Greg Wilkins <[email protected]>
|
@olamy I reverted the default |
|
I currently have this as a boolean on the error handler. It is not really a HttpCompliance issue. Perhaps we should create a JettyCompliance or ServletCompliance class? But I'm thinking having the boolean is OK for a start and if we add a compliance, then it can just set the boolean |
olamy
approved these changes
Feb 9, 2021
|
would be good to have some ini files with this. |
|
@olamy can't do an ini file because it is a per context configuration. Ultimately if we create another compliance instance, then we can have ini files to set the server-wide default, but will do as part of a different PR. |
|
@olamy merged to 11. Yell if you need help updating context.xml file for TCK to set this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5939 unwrap ServletException
Signed-off-by: Greg Wilkins [email protected]