Issue #6084 - CompressionPools should not be configured through the GzipHandler #6092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zipHandler. Signed-off-by: Lachlan Roberts <[email protected]>
…pressionPool capacity. Signed-off-by: Lachlan Roberts <[email protected]>
…Handler. Signed-off-by: Lachlan Roberts <[email protected]>
sbordet
requested changes
Mar 25, 2021
There was a problem hiding this comment.
@lachlan-roberts waiting for the setter methods for the pools.
sbordet
approved these changes
Mar 30, 2021
lachlan-roberts
deleted the
jetty-10.0.x-6084-GzipHandlerCompressionPool
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6084
The
InflaterPoolandDeflaterPoolshould be configured externally and set as a bean on the server. TheGzipHandlershould not be configuring them directly as they are shared with other components on the Server.