Issue #6268 Log max form size exceeded msg. #6301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Bartel <[email protected]>
gregw
reviewed
May 20, 2021
| @@ -436,6 +436,7 @@ private void commitSession(Session session) | |||
| } | |||
| catch (IllegalStateException | IllegalArgumentException e) | |||
| { | |||
| LOG.warn(e.getLocalizedMessage()); | |||
There was a problem hiding this comment.
Normally we've just logged e.toString(). Is this better?
There was a problem hiding this comment.
toString() calls getLocalizedMessage() after prepending the classname. I'll change it to toString().
Signed-off-by: Jan Bartel <[email protected]>
gregw
approved these changes
May 24, 2021
janbartel
added a commit
that referenced
this pull request
May 25, 2021
* Issue #6268 Log max form size exceeded msg. Signed-off-by: Jan Bartel <[email protected]>
janbartel
added a commit
that referenced
this pull request
May 25, 2021
* Issue #6268 Log max form size exceeded msg. Signed-off-by: Jan Bartel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6268
Log the
"Form is larger than max length ???"and"Cannot extract parameters with async IO"messages without stacktraces fromRequest.extractFormParameters()method to give better info on the server side rather than the genericBadMessageException"Unable to parse form content"message.