Explain EatWhatYouKill naming #6342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Greg Wilkins <[email protected]>
Signed-off-by: Greg Wilkins <[email protected]>
|
@gregw at the end it's a dynamic So perhaps it's time to call it |
sbordet
approved these changes
Jun 3, 2021
|
@sbordet I think you are right - the EWYK is now only one of several strategies that can be applied, and then when compared with PC & PEC it is clearer to describe it as EPC. I'll do the rename, but only in 10 and leave the EWYK as a deprecated superclass of it. |
|
@gregw EWYK should be a deprecated subclass of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some concern has been raised at the EatWhatYouKill strategy name (OK @sbordet you get I told you so rights).
This PR updates the javadoc to be clear about the reason for using that name in that the strategy is named after
a hunting proverb in the sense
that one should only kill to eat. The use of this phrase is not an endorsement of hunting nor killing of wildlife for
food or sport.