Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6323 - HttpClient requests with redirects gets stuck/never cal… #6355

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

sbordet
Copy link
Contributor

@sbordet sbordet commented Jun 3, 2021

…ls onComplete()

  • Reworked the total timeout handling.
  • Now a CyclicTimeouts handles the exchanges in each HttpDestination,
    and a CyclicTimeouts handles the exchanges in each HttpConnection
    (rather than in HttpChannel).
  • Now adjusting the total timeout for copied requests generated by
    redirects and authentication.

Signed-off-by: Simone Bordet [email protected]
(cherry picked from commit 2e7d174)

…ls onComplete()

* Reworked the total timeout handling.
* Now a CyclicTimeouts handles the exchanges in each HttpDestination,
and a CyclicTimeouts handles the exchanges in each HttpConnection
(rather than in HttpChannel).
* Now adjusting the total timeout for copied requests generated by
redirects and authentication.

Signed-off-by: Simone Bordet <[email protected]>
(cherry picked from commit 2e7d174)
@sbordet sbordet requested a review from gregw June 3, 2021 14:04
@sbordet
Copy link
Contributor Author

sbordet commented Jun 3, 2021

Forward port of #6334.

@sbordet sbordet merged commit 21aba4a into jetty-10.0.x Jun 4, 2021
@sbordet sbordet deleted the jetty-10.0.x-6323-review-httpclient-timeout branch June 4, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpClient gets stuck/never calls onComplete() when multiple requests with timeouts are sent
2 participants