Fixes #8558 - Idle timeout occurs on HTTP/2 with InputStreamResponseL… #8585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istener. The issue was that HttpReceiverOverHTTP2.ContentNotifier.offer() was racy, as a network thread could have offered a DATA frame, but not yet called process() -- yet an application thread could have stolen the DATA frame completed the response and started another response, causing the network thread to interact with the wrong response. The implementation has been changed so that HttpReceiverOverHTTP2.ContentNotifier does not have a queue anymore and it demands DATA frames to the Stream only when the application demands more -- a simpler model that just forwards the demand. Signed-off-by: Simone Bordet <[email protected]>
lorban
previously approved these changes
Sep 15, 2022
| try | ||
| { | ||
| if (progress.incrementAndGet() % 1000 == 0) | ||
| System.err.printf("progress %d/%d%n", progress.get(), requestCount); |
There was a problem hiding this comment.
This could be removed/commented out.
| } | ||
| catch (Exception e) | ||
| { | ||
| fail(e); |
There was a problem hiding this comment.
I'd prefer a rethrow as a RuntimeException.
...lient-transport/src/main/java/org/eclipse/jetty/http2/client/http/HttpReceiverOverHTTP2.java
Show resolved
Hide resolved
…istener. Updates after review. Signed-off-by: Simone Bordet <[email protected]>
lorban
approved these changes
Sep 15, 2022
sbordet
deleted the
jetty-10.0.x-8858-idle-timeout-http2-inputstreamresponselistener
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…istener.
The issue was that HttpReceiverOverHTTP2.ContentNotifier.offer() was racy, as a network thread could have offered a DATA frame, but not yet called process() -- yet an application thread could have stolen the DATA frame completed the response and started another response, causing the network thread to interact with the wrong response.
The implementation has been changed so that HttpReceiverOverHTTP2.ContentNotifier does not have a queue anymore and it demands DATA frames to the Stream only when the application demands more -- a simpler model that just forwards the demand.
Signed-off-by: Simone Bordet [email protected]