Issue #8606 - Fix to ContextScopeListener for AsyncIOServletTest #8619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
sbordet
approved these changes
Sep 27, 2022
…8606-scopeListeners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8606
This fixes the
ContextScopeListenerproblems inAsyncIOServletTestbut these tests still fail due to various other reasons some of which seem to be race conditions.Still looking the other failures which might take longer, but this PR is just to fix the
ContextScopeListenerusage.For EE10 there was an exit scope with no corresponding exit scope in
doStart(), which has now been fixed. For EE9 the jetty-coreContextScopeListenerwas trying to be registed on an EE9 specific class which requires the EE9ContextScopeListener.