Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty 12 - Restrict ResourceCollection to only hold directory entries #8630

Merged
merged 3 commits into from
Oct 10, 2022

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Sep 29, 2022

This is the experiment to see what happens when ResourceCollection is only allowed to hold directories.

@joakime joakime requested a review from gregw September 29, 2022 21:42
@joakime joakime self-assigned this Sep 29, 2022
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only tests failing are the newly added ones that explictly add a non directory resource. So this looks good to me.... once those tests are modified.

… and non-directory together in a ResourceCollection
@joakime joakime marked this pull request as ready for review October 5, 2022 18:30
@joakime joakime changed the title Jetty 12 - EXPERIMENT to see what happens if ResourceCollection can only hold directories Jetty 12 - Restrict ResourceCollection to only hold directory entries Oct 5, 2022
@joakime joakime requested a review from gregw October 5, 2022 18:30
@joakime joakime merged commit 73faf92 into jetty-12.0.x Oct 10, 2022
@joakime joakime deleted the jetty-12-resource-collection-only-dirs branch October 10, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants