Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand jetty properties when generating dry-run command line #8682

Merged

Conversation

lachlan-roberts
Copy link
Contributor

When using --dry-run, the command line printed was not resolving jetty properties.

For example using logging-jetty adds ${jetty.home.uri}/lib/logging/ to server classes.

However this is never resolved with the value of the jetty.home.uri property, and this is what is what ends up in server classes of the webapp when Jetty is started:

|  |     +> Serverclasses XWiki@c05fddc size=22
|  |     |  +> ${jetty.home.uri}/lib/logging/

this results in the ServiceConfigurationError seen in jetty/jetty.docker#118.

Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough.

@lachlan-roberts lachlan-roberts merged commit ccb2cc0 into jetty-10.0.x Oct 5, 2022
@lachlan-roberts lachlan-roberts deleted the jetty-10.0.x-jetty-start-expand-properties branch October 5, 2022 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants