Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty 12 - Re-enable some disabled session tests. #8714

Merged
merged 2 commits into from
Nov 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
* ReloadedSessionMissingClassTest
*/
//TODO
@Disabled
@ExtendWith(WorkDirExtension.class)
@Testcontainers(disabledWithoutDocker = true)
public class ReloadedSessionMissingClassTest
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
* WebAppObjectInSessionTest
*/
//TODO
@Disabled
@Testcontainers(disabledWithoutDocker = true)
public class WebAppObjectInSessionTest extends AbstractWebAppObjectInSessionTest
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import java.io.File;
import java.io.FileOutputStream;
import java.io.FileWriter;
import java.net.URL;

import jakarta.servlet.http.HttpServletResponse;
import org.eclipse.jetty.client.HttpClient;
Expand Down Expand Up @@ -74,22 +75,22 @@ public void testWebappObjectInSession() throws Exception
w.close();
File classesDir = new File(webInfDir, "classes");
classesDir.mkdir();
String packageName = WebAppObjectInSessionServlet.class.getPackage().getName();
File packageDirs = new File(classesDir, packageName.replace('.', File.separatorChar));
String packageName = File.separator + WebAppObjectInSessionServlet.class.getPackage().getName().replace('.', File.separatorChar) + File.separator;
File packageDirs = new File(classesDir, packageName);
packageDirs.mkdirs();

try (ResourceFactory.Closeable resourceFactory = ResourceFactory.closeable())
{
String resourceName = WebAppObjectInSessionServlet.class.getSimpleName() + ".class";
Resource resource = resourceFactory.newResource(getClass().getResource(resourceName));
Resource resource = resourceFactory.newResource(getClass().getResource(packageName + resourceName));

//File sourceFile = new File(getClass().getClassLoader().getResource(resourceName).toURI());
File targetFile = new File(packageDirs, resourceName);
//copy(sourceFile, targetFile);
IO.copy(resource.newInputStream(), new FileOutputStream(targetFile));

resourceName = WebAppObjectInSessionServlet.class.getSimpleName() + "$" + WebAppObjectInSessionServlet.TestSharedStatic.class.getSimpleName() + ".class";
resource = resourceFactory.newResource(getClass().getResource(resourceName));
resource = resourceFactory.newResource(getClass().getResource(packageName + resourceName));
//sourceFile = new File(getClass().getClassLoader().getResource(resourceName).toURI());
targetFile = new File(packageDirs, resourceName);
//copy(sourceFile, targetFile);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,14 @@ public void stop() throws Exception

public WebAppContext addWebAppContext(String warPath, String contextPath) throws Exception
{
//TODO
throw new UnsupportedOperationException("TODO!");
WebAppContext context = new WebAppContext(warPath, contextPath);
SessionHandler sessionHandler = newSessionHandler();
sessionHandler.setSessionIdManager(_sessionIdManager);
sessionHandler.setMaxInactiveInterval(_maxInactivePeriod);
context.setSessionHandler(sessionHandler);
_contexts.addHandler(context);

return context;
}

public Server getServer()
Expand Down
Binary file not shown.
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Jetty Logging using jetty-slf4j-impl
#org.eclipse.jetty.LEVEL=DEBUG
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
org.slf4j.simpleLogger.defaultLogLevel=info
org.slf4j.simpleLogger.log.org.eclipse.jetty.session.MariaDbLogs=error
org.slf4j.simpleLogger.log.org.eclipse.jetty.session.JdbcTestHelper=info
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@
/**
* ReloadedSessionMissingClassTest
*/
//TODO
@Disabled
@ExtendWith(WorkDirExtension.class)
@Testcontainers(disabledWithoutDocker = true)
public class ReloadedSessionMissingClassTest
Expand Down Expand Up @@ -115,6 +113,7 @@ public void testSessionReloadWithMissingClass() throws Exception
assertNotNull(sessionId);

//Stop the webapp
webApp.get().stop();
webApp.stop();

webApp.setClassLoader(loaderWithoutFoo);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
/**
* WebAppObjectInSessionTest
*/
//TODO
@Disabled
@Testcontainers(disabledWithoutDocker = true)
public class WebAppObjectInSessionTest extends AbstractWebAppObjectInSessionTest
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,22 +74,22 @@ public void testWebappObjectInSession() throws Exception
w.close();
File classesDir = new File(webInfDir, "classes");
classesDir.mkdir();
String packageName = WebAppObjectInSessionServlet.class.getPackage().getName();
File packageDirs = new File(classesDir, packageName.replace('.', File.separatorChar));
String packageName = File.separator + WebAppObjectInSessionServlet.class.getPackage().getName().replace('.', File.separatorChar) + File.separator;
File packageDirs = new File(classesDir, packageName);
packageDirs.mkdirs();

try (ResourceFactory.Closeable resourceFactory = ResourceFactory.closeable())
{
String resourceName = WebAppObjectInSessionServlet.class.getSimpleName() + ".class";
Resource resource = resourceFactory.newResource(getClass().getResource(resourceName));
Resource resource = resourceFactory.newResource(getClass().getResource(packageName + resourceName));

//File sourceFile = new File(getClass().getClassLoader().getResource(resourceName).toURI());
File targetFile = new File(packageDirs, resourceName);
//copy(sourceFile, targetFile);
IO.copy(resource.newInputStream(), new FileOutputStream(targetFile));

resourceName = WebAppObjectInSessionServlet.class.getSimpleName() + "$" + WebAppObjectInSessionServlet.TestSharedStatic.class.getSimpleName() + ".class";
resource = resourceFactory.newResource(getClass().getResource(resourceName));
resource = resourceFactory.newResource(getClass().getResource(packageName + resourceName));
//sourceFile = new File(getClass().getClassLoader().getResource(resourceName).toURI());
targetFile = new File(packageDirs, resourceName);
//copy(sourceFile, targetFile);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,14 @@ public void stop() throws Exception

public WebAppContext addWebAppContext(String warPath, String contextPath) throws Exception
{
//TODO
throw new UnsupportedOperationException("TODO!");
WebAppContext context = new WebAppContext(warPath, contextPath);
SessionHandler sessionHandler = newSessionHandler();
sessionHandler.getSessionManager().setSessionIdManager(_sessionIdManager);
sessionHandler.setMaxInactiveInterval(_maxInactivePeriod);
context.setSessionHandler(sessionHandler);
_contexts.addHandler(context);

return context;
}

public Server getServer()
Expand Down