Moved FastCGIProxyServlet in ee9 to FastCGIProxyHandler in core. #8718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved TryFilesFilter in ee9 to TryPathsHandler in core. Update Jetty modules to properly setup the class-path in case of proxy usage. Updated and expanded test cases. Signed-off-by: Simone Bordet <[email protected]>
The problem is that fcgi-proxy depends on fcgi-client, so both will be put on the module-path. However, fcgi-server is used for the tests, it is in the class-path, but depends on fcgi-client that is on the module-path. Therefore, when a fcgi-server class tries to access a fcgi-client class, JPMS throws because the fcgi-client module does not export to the unnamed module. Signed-off-by: Simone Bordet <[email protected]>
joakime
requested changes
Oct 17, 2022
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpTester.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/TryPathsHandler.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-fcgi/jetty-fcgi-proxy/src/main/config/modules/fcgi-proxy.mod
Show resolved
Hide resolved
jetty-core/jetty-fcgi/jetty-fcgi-server/src/main/config/modules/fcgi.mod
Show resolved
Hide resolved
...istribution-common/src/test/java/org/eclipse/jetty/tests/distribution/DistributionTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Simone Bordet <[email protected]>
joakime
approved these changes
Oct 17, 2022
…d on the fcgi module, which is only used in tests. Signed-off-by: Simone Bordet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved TryFilesFilter in ee9 to TryPathsHandler in core. Update Jetty modules to properly setup the class-path in case of proxy usage.
Updated and expanded test cases.
Signed-off-by: Simone Bordet [email protected]