Jetty 12 - Re-enabled distribution tests that were disabled. #8722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simone Bordet <[email protected]>
joakime
approved these changes
Oct 18, 2022
| public void testSimpleWebAppWithJSPOnModulePath(String env) throws Exception | ||
| { | ||
| // Testing with env=ee9 is not possible because jakarta.transaction:1.x | ||
| // does not have a proper module-info.java, so JPMS resolution will fail. |
There was a problem hiding this comment.
Sounds like a new issue needs to be filed for this
There was a problem hiding this comment.
A new issue to what project?
I don't think it can be fixed, as jakarta.transaction:1.x should remain Java 8 compatible (so no module-info.java) as per JEE 9.
It only has an Automatic-Module-Name but that is not enough to run with full JPMS.
I don't think the JakartaEE project will modify the jar, since they have already fixed it in jakarta.transaction:2.x (and in fact, our ee10 tests pass without problems).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Simone Bordet [email protected]