ResourceHandler set base resource as string #8735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-setBaseResource-string
…-setBaseResource-string
+ Fix XML names + fix the anti-pattern of setBaseResourceAsPath(someResource.getPath())
fixed tests
joakime
approved these changes
Oct 20, 2022
| */ | ||
| @ManagedAttribute("document root for context") | ||
| @Deprecated |
There was a problem hiding this comment.
Can't we just delete this method now?
There was a problem hiding this comment.
I think we should keep it in ee9 as we are trying to be as compatible as possible with jetty-10.
We can remove in 12.1.0
There was a problem hiding this comment.
We already changed the contract from jetty-10 though.
Resource.newResource(String) no longer exists.
Have to use ResourceFactory.newResource(String) now.
There was a problem hiding this comment.
yeah, there are changes, but it costs us nothing much to hold onto a deprecated method for at least a few release cycles.
We could remove it, but it can be a confusing name change, so leaving it as a sign post is a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added convenience method to set resource from a string. Closes #8727.