Jetty 12 - Fix GzipHandler handling of chunked and Content-Length
#8927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joakime
added
Http Client
joakime
commented
Nov 23, 2022
jetty-core/jetty-server/src/test/java/org/eclipse/jetty/server/RequestTest.java
Show resolved
Hide resolved
joakime
commented
Nov 23, 2022
jetty-core/jetty-server/src/test/java/org/eclipse/jetty/server/RequestTest.java
Show resolved
Hide resolved
joakime
commented
Nov 23, 2022
...y-core/jetty-server/src/test/java/org/eclipse/jetty/server/handler/gzip/GzipHandlerTest.java
Show resolved
Hide resolved
joakime
commented
Nov 23, 2022
...y-core/jetty-server/src/test/java/org/eclipse/jetty/server/handler/gzip/GzipHandlerTest.java
Show resolved
Hide resolved
…enable-http2-gzip-test
joakime
changed the title
ContentLengthTest.testGzippedContentLengthAddedByServerGzipHandler handling of chunked and Content-Length
joakime
removed
the
Http Client
gregw
requested changes
Nov 30, 2022
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/gzip/GzipResponse.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/gzip/GzipResponse.java
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/gzip/GzipResponse.java
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/gzip/GzipResponse.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/gzip/GzipResponse.java
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/gzip/GzipResponse.java
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/gzip/GzipResponse.java
Show resolved
Hide resolved
gregw
approved these changes
Dec 5, 2022
…enable-http2-gzip-test
…enable-http2-gzip-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
GzipResposne(used byGzipHandler) doesn't guaranteeContent-Lengthfor simple responses the response headers.This PR fixes
GzipResponsedeflation, and also addresses a few small bugs aroundHEADresponses during HTTP/2 and HTTP/3