Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty-12 Rewrite RuleProcessor #8934

Merged
merged 5 commits into from
Nov 25, 2022
Merged

Jetty-12 Rewrite RuleProcessor #8934

merged 5 commits into from
Nov 25, 2022

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Nov 24, 2022

This extracts some goodness from the closed #8793.
This PR decouples the rewrite module from the WrapperProcessor class, which is being considered for significant refactoring or removal. Having a module specific version of that class allows better code readability and a more appropriate API that avoids duplication request instances.

This decouples the rewrite module from the `WrapperProcessor` class, which is being considered for significant refactoring or removal.
Having a module specific version of that class allows better code readability and a more appropriate API that avoids duplication request instances.
@gregw gregw added the jetty 12 label Nov 24, 2022
@gregw gregw requested review from lorban, sbordet and joakime November 24, 2022 03:54
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the process(Response, Callback) method.

All the rest I am not sure.
Not sure whether having 2 abstractions that represent the same thing (a request wrapper that is also a request processor) makes sense.
Definitely not sold about reusability that I would remove for now from this PR until we settle on a decision.

@gregw
Copy link
Contributor Author

gregw commented Nov 24, 2022

@sbordet I removed all the residual re-use code (that was unintentional included by refactor).

I don't mind having two abstractions for Request + Processor, as I believe they will diverge as we clean up the issues in the Handler tree.
If they don't then, it will be trivial to change the parent of Rule.Processor to the common one. For now, the separation will allow us to experiment with Handlers without constantly breaking/fixing rewrite.

@gregw gregw requested a review from sbordet November 24, 2022 21:39
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just clean up Rule.Processor as per comments.

@gregw gregw merged commit 0959436 into jetty-12.0.x Nov 25, 2022
@gregw gregw deleted the jetty-12-typed-rewrite branch November 25, 2022 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants