PathMappings optimizations #9055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid iterations if only ServletPathSpec instances Avoid tests for empty mappings. Better reset implementation
Avoid iterations if only ServletPathSpec instances Avoid tests for empty mappings. Better reset implementation
|
This is a more comprehensive alternative to #9053 |
joakime
requested changes
Dec 15, 2022
jetty-http/src/main/java/org/eclipse/jetty/http/pathmap/PathMappings.java
Show resolved
Hide resolved
Improve suffix matching
janbartel
previously approved these changes
Dec 16, 2022
jetty-http/src/main/java/org/eclipse/jetty/http/pathmap/PathMappings.java
Show resolved
Hide resolved
Improve exact matching
|
It feels like a set of micro benchmarks would help now that this class' perf appeared on the radar. |
Maybe, but these changes are primarily removing work that was never actually necessary, so it is more of a bug fix than an optimization. I don't think we should hold up a merge of this whilst over analyzing it. I'd like to get this merged and only if we then see it on flame graphs should we drill down with micro benchmarks. |
joakime
reviewed
Dec 19, 2022
jetty-http/src/main/java/org/eclipse/jetty/http/pathmap/PathMappings.java
Show resolved
Hide resolved
joakime
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid iterations if only ServletPathSpec instances
Avoid tests for empty mappings.
Better reset implementation