Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
elm-review --watch
on Windows, the first review works successfully, but after a change is made to a file, the following error occurs:It appears that the first run uses file paths that have been made OS-agnostic (i.e. which uses
/
instead of\
), but the path from the watcher is not made OS-agnostic, so it creates a situation where elm-review thinks the same file is at two different paths.The initial loading of files in
elm-files.js
callsOsHelpers.makePathOsAgnostic
on the path.node-elm-review/lib/elm-files.js
Lines 158 to 163 in d35e821
This function matches the
removeWindowsSeparators
function inwatch.js
, so I replaced its usages, as well as adding usages that were missing.node-elm-review/lib/os-helpers.js
Lines 1 to 3 in d35e821
node-elm-review/lib/watch.js
Lines 291 to 293 in d35e821