Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradle - skip uploading JAR if no jar produced in build #538

Merged
merged 1 commit into from
Jul 18, 2021
Merged

Gradle - skip uploading JAR if no jar produced in build #538

merged 1 commit into from
Jul 18, 2021

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Jul 16, 2021

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

If Maven publication with components.java exist, but there are no JARs produced in the build, don't fail the build.
Instead log the returned exception with information about the project and the publication.
For example:

Illegal state detected at Maven publication: 'mavenJava', project ':api': Artifact api.jar wasn't produced by this build.

@yahavi yahavi requested a review from eyalbe4 July 16, 2021 17:15
@yahavi yahavi self-assigned this Jul 16, 2021
@yahavi yahavi merged commit 7d9d1b4 into jfrog:master Jul 18, 2021
@yahavi yahavi deleted the gradle-pub-jar branch July 18, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

Assignees

@yahavi yahavi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yahavi @eyalbe4