Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for new Xray graph scan (Xray java client) #556

Merged
merged 6 commits into from
Sep 30, 2021
Merged

Add support for new Xray graph scan (Xray java client) #556

merged 6 commits into from
Sep 30, 2021

Conversation

talarian1
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

@talarian1 talarian1 requested a review from eyalbe4 September 26, 2021 08:06
yahavi
yahavi requested changes Sep 26, 2021
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Please consider my comments and the following general guidelines:

  • Add some tests to DependencyTreeTest.
  • Make sure to reformat code.
  • Make sure to suppress or handle compiler warnings.

build-info-extractor/src/main/java/org/jfrog/build/extractor/scan/DependencyTree.java Outdated Show resolved Hide resolved
build-info-extractor/src/main/java/org/jfrog/build/extractor/scan/DependencyTree.java Outdated Show resolved Hide resolved
build-info-extractor/src/main/java/org/jfrog/build/extractor/scan/DependencyTree.java Outdated Show resolved Hide resolved
build-info-extractor/src/main/java/org/jfrog/build/extractor/scan/DependencyTree.java Outdated Show resolved Hide resolved
build-info-extractor/src/main/java/org/jfrog/build/extractor/scan/DependencyTree.java Outdated Show resolved Hide resolved
build-info-extractor/src/main/java/org/jfrog/build/extractor/scan/DependencyTree.java Show resolved Hide resolved
build-info-extractor/src/main/java/org/jfrog/build/extractor/scan/License.java Outdated Show resolved Hide resolved
build-info-extractor/src/main/java/org/jfrog/build/extractor/scan/License.java Outdated Show resolved Hide resolved
build-info-extractor/src/main/java/org/jfrog/build/extractor/scan/Artifact.java Outdated Show resolved Hide resolved
@talarian1 talarian1 merged commit 4e75c75 into jfrog:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi requested changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@talarian1 @yahavi