Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apache commons-lang (2) to current commons-lang3 #580

Merged
merged 1 commit into from
Dec 5, 2021

Conversation

ebariaux
Copy link
Contributor

@ebariaux ebariaux commented Dec 5, 2021

See issue jfrog/jenkins-artifactory-plugin#556, PR jfrog/jenkins-artifactory-plugin#567 was not sufficient to ensure commons-lang 2 is not included in the libs of the built plugin, it should also be removed from the dependant projects, including this one.

@github-actions
Copy link

github-actions bot commented Dec 5, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ebariaux
Copy link
Contributor Author

ebariaux commented Dec 5, 2021

I have read the CLA Document and I hereby sign the CLA

Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@yahavi yahavi merged commit fdf5320 into jfrog:master Dec 5, 2021
@yahavi yahavi mentioned this pull request Dec 5, 2021
1 task
@ebariaux
Copy link
Contributor Author

ebariaux commented Dec 6, 2021

Today while performing further testing on our Jenkins, I had a failure because of this change.
The build-info-extractor-docker is relying on com.github.docker-java component, which is still using commons lang 2.
This caused an exception in the Jenkins plugin.
I've created a PR on docker-java to also migrate it to commons lang 3, see docker-java/docker-java#1746
When referencing that updated version from this project and re-building the Jenkins Artifactory Plugin issue was solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants