Bugfix - Gradle defaults props should not ignore deprecated build-inf… #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyalbe4
requested changes
Dec 27, 2021
...actor/src/main/java/org/jfrog/build/extractor/clientConfiguration/PrefixPropertyHandler.java
Outdated
Show resolved
Hide resolved
...actor/src/main/java/org/jfrog/build/extractor/clientConfiguration/PrefixPropertyHandler.java
Outdated
Show resolved
Hide resolved
...nfo-extractor-gradle/src/test/java/org/jfrog/gradle/plugin/artifactory/GradlePluginTest.java
Show resolved
Hide resolved
yahavi
reviewed
Aug 5, 2022
| }}; | ||
| // Run Gradle | ||
| BuildResult buildResult = runGradle(gradleVersion, extendedEnv, true); | ||
| // Check results |
There was a problem hiding this comment.
Looks like this line is missing below "Check results":
checkBuildResults(artifactoryManager, buildResult, VersionNumber.parse(gradleVersion).getMajor() >= 6, localRepo1);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o properties
Build-info properties file may include deprecated properties that have 'artifactory' as their prefix. since Gradle may generate defaults to the none deprecated keys we need to look for the deprecated keys first.
Resolves: