Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - Use the correct plugins endpoints #635

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

kamrup
Copy link
Contributor

@kamrup kamrup commented Apr 4, 2022

This wrong endpoints seem to have been used since
67cefb2.

jfrog/jenkins-artifactory-plugin#659

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@kamrup
Copy link
Contributor Author

kamrup commented Apr 4, 2022

I have read the CLA Document and I hereby sign the CLA

@kamrup
Copy link
Contributor Author

kamrup commented Apr 4, 2022

I'm not sure if the changes require new tests - they don't seem to be covered at the moment.
I tried running the Extractor tests as mentioned in the README but they fail for what seem to be unrelated reasons.

@kamrup kamrup marked this pull request as ready for review April 4, 2022 20:52
@Or-Geva Or-Geva self-requested a review April 5, 2022 06:19
@Or-Geva
Copy link
Contributor

Or-Geva commented Apr 5, 2022

@kamrup, thank you for your contribution. I apologize for the inconvenience caused by the wrong endpoints for Execute and Get UserPlugin. To be sure, I checked the other UserPlugin endpoints (getStagingStrategy & executeUserPlugin) and they are all ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants