Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Docker Manifest path for collecting build-info #643

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Fix Docker Manifest path for collecting build-info #643

merged 2 commits into from
Apr 20, 2022
+34 −6

Conversation

Or-Geva
Copy link
Contributor

@Or-Geva Or-Geva commented Apr 14, 2022 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

The function getArtManifestPath generates four potential paths to search docker manifests in Artifactory
The 'Assume proxy-less' path is being generated incorrectly.

@Or-Geva Or-Geva requested a review from eyalbe4 April 14, 2022 14:12
@Or-Geva Or-Geva merged commit 58ca0ed into jfrog:master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Or-Geva @yahavi