Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sha256 hashes being set to literal "SHA-256" in build-info json #669

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Fix sha256 hashes being set to literal "SHA-256" in build-info json #669

merged 1 commit into from
Nov 10, 2022

Conversation

sll552
Copy link
Contributor

@sll552 sll552 commented Oct 13, 2022 •
edited
Loading

fixes #674

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

@github-actions
Copy link

github-actions bot commented Oct 13, 2022 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sll552
Copy link
Contributor Author

sll552 commented Oct 13, 2022

I have read the CLA Document and I hereby sign the CLA

@sll552
Copy link
Contributor Author

sll552 commented Oct 13, 2022

recheck

@sll552
Copy link
Contributor Author

sll552 commented Oct 13, 2022

This was introduced as part of 6f1cab7 so maybe @yahavi could you take a look?

@sll552 sll552 mentioned this pull request Nov 9, 2022
Closed
@RobiNino RobiNino merged commit 789f3e7 into jfrog:master Nov 10, 2022
@RobiNino
Copy link
Contributor

Thanks a lot @sll552 !

@sll552 sll552 deleted the fix_sha256 branch November 10, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sha256 hashes are set to literal "SHA-256" in build-info json
2 participants
@sll552 @RobiNino