Only trim spaces of array parameter entries #670
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some packages include a space in the names of their license. In particular this is a problem with "Public Domain" in org.json:json here: https://github.com/stleary/JSON-java/blob/master/pom.xml#L32 Add a new function to read an array of strings from an environment variable that does not remove all spaces but only ones at the beginning and end of each individual entry. This preserves spaces inside the entries. Read list of allowed licenses using this new function.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Given, that the license for the org.json:json package was updated in Artifactory to CC0-1.0 (I think?) this is not an issue anymore for us. But feel free to reopen in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some packages include a space in the names of their license. In particular this is a problem with “Public Domain” in org.json:json here: https://github.com/stleary/JSON-java/blob/master/pom.xml#L32
I added the function to read the list of allowed licenses from the environment variable that does not remove all spaces but only ones at the beginning and end of each individual entry. This preserves spaces inside the entries. I have updated a unit test to cover this change.
Note: While all unit tests are passing, the GitHub Job “Scan Pull Request Tests” fails in my fork. This, however, appears not to be related to my change, as these were failing before as well. I think this may be caused by a different JFrog server version that reports some vulnerabilities slightly different from what is expected by these tests.
Please let me know if I need to change anything to move this PR forward.