[JENKINS-74044] Extract inline JavaScript from repos.jelly

jfrog · Nov 27, 2024 · 728d8e9 · 728d8e9
1 parent 61062e3
commit 728d8e9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/src/main/resources/lib/jfrog/repos.jelly b/src/main/resources/lib/jfrog/repos.jelly
@@ -24,13 +24,9 @@
 
     <f:entry>
         <div style="float:right">
-            <input type="button" value="${%Refresh Repositories}" class="yui-button validate-button"
-                   onclick="repos(this,
-                                '${jsFunction}',
-                                '${uniqueId}',
-                                '${repoUrl}',
-                                '${credentialsDescriber}',
-                                 ${bind})"/>
+            <button type="button" class="jenkins-button validate-button artifactory-refresh-repos-button"
+                    data-js-function="${jsFunction}" data-unique-id="${uniqueId}" data-repo-url="${repoUrl}"
+                    data-credentials-describer="${credentialsDescriber}" data-stapler-proxy-name="${bind}">${%Refresh Repositories}</button>
 
         </div>
         <div style="display:none;">

diff --git a/src/main/resources/lib/jfrog/repos/repos.js b/src/main/resources/lib/jfrog/repos/repos.js
@@ -515,6 +515,15 @@ document.addEventListener("DOMContentLoaded", () => {
             setStagingParamsSelectedValue(event.target);
         });
     });
+
+    document.querySelectorAll(".artifactory-refresh-repos-button").forEach((button) => {
+        button.addEventListener("click", (event) => {
+            const target = event.target;
+            const { jsFunction, uniqueId, repoUrl, credentialsDescriber, staplerProxyName } = target.dataset;
+
+            repos(target, jsFunction, uniqueId, repoUrl, credentialsDescriber, window[staplerProxyName]);
+        });
+    });
 });
 
 Behaviour.specify("BUTTON.artifactory-toggle-txt-and-select", "dynamicRepos_artifactory-toggle-txt-and-select", 0, (element) => {